FullCubeMask improvements#2952
Open
TomyLobo wants to merge 4 commits into
Open
Conversation
octylFractal
requested changes
Apr 20, 2026
TomyLobo
force-pushed
the
fullcube-double-slabs
branch
2 times, most recently
from
April 26, 2026 14:36
a9b08cf to
96ac382
Compare
octylFractal
requested changes
Apr 29, 2026
TomyLobo
force-pushed
the
fullcube-double-slabs
branch
2 times, most recently
from
April 30, 2026 01:57
0218ea0 to
2bc7474
Compare
me4502
requested changes
May 3, 2026
TomyLobo
force-pushed
the
fullcube-double-slabs
branch
from
May 3, 2026 20:19
2bc7474 to
46d5a63
Compare
TomyLobo
force-pushed
the
fullcube-double-slabs
branch
2 times, most recently
from
May 10, 2026 11:30
bfe24f6 to
11ff9a0
Compare
Member
|
Would you be able to please extract the two shared commits into their own PR, so that they can be reviewed separately from the two PRs that make use of them? I feel like they are in a much more mergeable state, and it would make the other two PRs more reviewable / simpler to understand once those are in (alongside becoming squashable/etc) |
This excludes, for instance, rose bushes, which are #fullcube, but are visually smaller.
TomyLobo
force-pushed
the
fullcube-double-slabs
branch
from
July 12, 2026 00:36
11ff9a0 to
403a4a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This shares 2 commits with #2960, please don't squash.