Skip to content

added schedule change detection notification - #384

Open
yeti107 wants to merge 2 commits into
EuroPython:mainfrom
yeti107:post-schedule-updates-373
Open

added schedule change detection notification#384
yeti107 wants to merge 2 commits into
EuroPython:mainfrom
yeti107:post-schedule-updates-373

Conversation

@yeti107

@yeti107 yeti107 commented Jul 28, 2026

Copy link
Copy Markdown

The bot now ...

  • compares newly fetched schedules against previous schedule
  • detects changes to existing sessions
  • sends notification to the configured schedule updates channel

Method/Implementation

-Added ScheduleChange model for changed sessions
-Added schedule comparison logic in ProgrammeConnector
-Updated the schedule fetch task to send notifs when changes are detected
-Added tests for schedule comparison and notification handling

Ran tests/program_notifications and all 41 passed

@NMertsch

NMertsch commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Hi @yeti107 thank you for this PR. I hope this feedback is useful:

Missing functionality:

  • I think your PR does not detect new or cancelled sessions.

Schedule change notifications:

  • Schedule updates should mention if the title or speakers change.
  • Schedule updates should always include the speaker, title, time and room. Users might be interested in "Hynek's talk" or "The talk right after lunch" without remembering the title.
  • Room changes should be formatted for humans, not machines. Example: "Room changed: S1 -> S1, S2"
  • Start time and duration should be treated as a single piece of information. Example: "Time changed: Thu 13:00 - 13:30 -> Fri 14:00 -> 14:30".
  • The date and time formatting should be programmed explicitly, instead of relying on the server's locale.

Implementation

  • ProgrammeConnector.fetch_schedule() should fetch the schedule. It should not return a list of schedule changes.
  • Cog.fetch_schedule() should fetch the schedule. It should not send messages about schedule changes.
  • I don't think this PR should modify mock_schedule.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants