Repository navigation
fix: redact credentials in JSON snippets #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
imxyanua
wants to merge
2
commits into
EvoMap:main
Choose a base branch
from
imxyanua:codex/fix-json-credential-redaction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−1
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import assert from 'node:assert/strict'; | ||
| import { test } from 'node:test'; | ||
|
|
||
| import { candidateOf } from '../lib/distill/candidate.js'; | ||
| import { distillBody, distillPrompt } from '../lib/distill/prompt.js'; | ||
| import { containsSecret, withoutSecrets } from '../lib/redact.js'; | ||
|
|
||
| test('redaction removes the complete JSON string and leaves unrelated fields', () => { | ||
| const text = JSON.stringify({ API_KEY: 'fixture "quoted" \\ tail', topic: 'retry' }); | ||
| assert.equal(containsSecret(text), true); | ||
| assert.deepEqual(JSON.parse(withoutSecrets(text)), { API_KEY: '[redacted]', topic: 'retry' }); | ||
| assert.equal(containsSecret(withoutSecrets(text)), false); | ||
| assert.equal(withoutSecrets('token=fixtureCredential123456'), '[redacted]'); | ||
| }); | ||
|
|
||
| test('camelCase JSON credentials are redacted without removing ordinary keys', () => { | ||
| const ordinary = { maxTokens: '4096', monkey: 'example' }; | ||
| const text = JSON.stringify({ accessToken: 'fixture access', refreshToken: 'fixture "quoted" \\ tail', dbPassword: 'fixture password', ...ordinary }); | ||
| assert.equal(containsSecret(text), true); | ||
| const redacted = withoutSecrets(text); | ||
| assert.deepEqual(JSON.parse(redacted), { accessToken: '[redacted]', refreshToken: '[redacted]', dbPassword: '[redacted]', ...ordinary }); | ||
| assert.equal(containsSecret(redacted), false); | ||
| assert.equal(withoutSecrets(redacted), redacted); | ||
| }); | ||
|
|
||
| test('the saved candidate, model prompt and Proxy body exclude JSON credentials', () => { | ||
| const secret = /fixture(?:Credential|Refresh)123456/; | ||
| const detail = JSON.stringify({ password: 'fixtureCredential123456', refreshToken: 'fixtureRefresh123456' }); | ||
| const candidate = candidateOf({ | ||
| prompt: 'Fix upload retry with ' + detail, | ||
| record: { | ||
| answer: 'Retry now works with ' + detail, | ||
| commands: ['npm test -- ' + detail], | ||
| paths: [], | ||
| checks: [{ command: 'npm test -- ' + detail, failed: false }], | ||
| }, | ||
| }); | ||
| const body = distillBody({ platform: 'test', sessionId: 'test-session', candidate, args: { summary: 'Repair upload retry' } }); | ||
| for (const text of [JSON.stringify(candidate), distillPrompt(candidate, detail), JSON.stringify(body)]) { | ||
| assert.doesNotMatch(text, secret); | ||
| assert.match(text, /\[redacted\]/); | ||
| assert.match(text, /upload retry/); | ||
| } | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
任意
*Key字段都会被当作秘密,破坏普通任务上下文🟠 严重程度:中(P2)
camelCase 正则无条件匹配所有以
Key结尾的 JSON 键,因此primaryKey、foreignKey、partitionKey、sortKey、cacheKey、objectKey等普通标识字段都会被替换为[redacted]。仅验证小写monkey并不能覆盖这些常见良性字段。Finding:
finding_f328919c91f59a1f6af8267c