Skip to content

fix: omit project snapshots with quoted JSON credentials - #40

Draft
imxyanua wants to merge 2 commits into
EvoMap:feat/background-distill-evidencefrom
imxyanua:codex/fix-project-snapshot-credential-redaction
Draft

imxyanua wants to merge 2 commits into
EvoMap:feat/background-distill-evidencefrom
imxyanua:codex/fix-project-snapshot-credential-redaction

Conversation

@imxyanua

@imxyanua imxyanua commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Omit the entire project diff when an ordinary JSON file contains a credential under a quoted key. The filter runs at snapshot creation and again when building the distillation request, which also protects candidates saved before the update. Proxy replay still receives clean diffs byte for byte.

Evidence

  • Before, both the snapshot and request regressions failed with synthetic JSON data.
  • After, the snapshot and request regressions pass. The focused Windows suite passed 25 tests with one filesystem-specific skip.

Merge Danger

Door: Two-way
Blast Radius: Distillation snapshots and the shared redaction filter.

Targets the head branch of #39. The quoted-key filter overlaps #33, so keep one shared implementation when integrating both.

@evomap-aiqa-bot

evomap-aiqa-bot Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Sentinel 已审核此变更,未发现已核验问题,但发现需要人工确认的风险。

另有 1 个需要人工确认的风险;黄色 advisory 不阻塞合并,建议开发 agent review advisory 评论并逐条确认。

开发 agent 查询详情: 调用 MCP 工具 sentinel_pr_review_context,传入 owner_repo="evomap/evolver-agent-plugin"、pr_number=40、head_sha="ff24e8769271fd19d31e15aee08242a5cf229b28",并按条目追加 finding_id 或 finding_key。

由 Sentinel 审核 · 目标提交 ff24e8769271

@evomap-aiqa-bot

Copy link
Copy Markdown

Sentinel 保留了 1 个尚未确认的审核候选。这些黄色条目不阻塞合并;红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
开发 agent:请 review 以下 advisory,并逐条给出“已验证无风险 / 已修复 / 转为后续事项”的结论;不要只做整体确认。

  • [P3] 无法识别常见的 camelCase JSON 凭据键 — 新增的 JSON_SECRET 只识别精确键名、连字符/下划线形式,以及带下划线的后缀键;常见的 ...(truncated) · ``lib/redact.js`` · advisory_f37877818767bf3c3dd8b09e`

需要完整证据时,可用行末 finding_key 查询 Sentinel PR review context。

由 Sentinel 审核 · 目标提交 ff24e8769271

@evomap-aiqa-bot

evomap-aiqa-bot Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Sentinel 已审核此变更,未发现已核验问题,但发现需要人工确认的风险。

另有 1 个需要人工确认的风险;黄色 advisory 不阻塞合并,建议开发 agent review advisory 评论并逐条确认。

开发 agent 查询详情: 调用 MCP 工具 sentinel_pr_review_context,传入 owner_repo="evomap/evolver-agent-plugin"、pr_number=40、head_sha="a82ace764c7e019842c2ed483bf511e207dfce4b",并按条目追加 finding_id 或 finding_key。

由 Sentinel 审核 · 目标提交 a82ace764c7e

@evomap-aiqa-bot

Copy link
Copy Markdown

Sentinel 保留了 1 个尚未确认的审核候选。这些黄色条目不阻塞合并;红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
开发 agent:请 review 以下 advisory,并逐条给出“已验证无风险 / 已修复 / 转为后续事项”的结论;不要只做整体确认。

  • [P3] JSON 凭据值为对象或数组时可绕过新增过滤 — 新增正则仅接受 "credentialKey":"string"。合法 JSON 如 "token":{"value":"opaque-secret"} 或 "token":["op...(truncated) · ``lib/redact.js`` · advisory_fd3fbcebf1e722381ffc6ccf`

需要完整证据时,可用行末 finding_key 查询 Sentinel PR review context。

由 Sentinel 审核 · 目标提交 a82ace764c7e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant