feat(skill-store): report Hub install-success after local fetch commit - #622
Merged
Conversation
Wire B-5/KDP-3 POST /a2a/skill/store/:id/install-success after evolver fetch --skill writes files, so trending can count unique successful installs without treating download attempts as popularity.
|
Sentinel 正在审核此变更,尚未形成最终结论。 大 PR 拆片审核中
开发 agent 查询详情: 调用 MCP 工具 由 Sentinel 审核 · 目标提交 6e8c0555dca8 |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After
evolver fetch --skillsuccessfully writes a Hub skill to disk, POST Hub/a2a/skill/store/:id/install-successso B-5 / KDP-3 trailing-30d unique-install trending can populate.Scope and cuts
Outcome: Evolver clients that complete a local Hub skill install commit now emit install-success (fail-soft; disk write already landed).
Cuts / 缩减的范围:
evolver fetch --skill). Owner: website.evomap.ai/market/skill/:idexternally (#8128); no local Hub install commit path yet. Owner: desktop plugins.What changed
src/gep/skillInstallSuccess.jshelper + focused testsindex.jsfetch path gates onskillInstallCommittedthen reports with node_secret authHow to test
Risk
Low — additive fail-soft Hub POST after successful local write; download path unchanged.
Harness/evaluator governance
Upstream governance surface:
src/gep/skillInstallSuccess.jsHub Skill Store client confirm only (post-local-commit install-success POST); no GEP schema, selector, mutation, solidify, evaluator, or evolve-pipeline change.Downstream EvoX impact: Desktop/website still do not install Hub skills locally; when they shell out to
evolver fetch --skill, trending can populate. No Wails/bridge/protocol contract change in this PR.Rollout-local scope: Applies only after a successful on-disk skill write from
evolver fetch --skill; report failures are fail-soft and leave local files intact.Promotion boundary: Merge makes install-success reporting the default for the fetch--skill path only; no live Hub ranking promotion or evaluator promotion is performed by this PR.
Evaluator mismatch sets: Observation unchanged for evolution candidates; action adds one authenticated Hub confirm after local install commit; repair none (fail-soft skip); verification covers helper unit tests plus source-level wiring/fetch security guards; evidence is focused
node --testoutput; belief unchanged for harness approval/scoring.Non-regression evidence:
node --test test/skillInstallSuccess.test.js test/fetchSecurity.test.js(10/10 pass); download path and path-traversal guards unchanged.Fix-severity review: low
Owner approval: Skill Store / Hub A2A client owner review sufficient; no evaluator owner sign-off required.
Security boundary: Reuses existing node_secret Hub auth and hubFetch egress; body is
{ sender_id }only — no transcript, KB, filenames, or prompt content uploaded.Rollback: Revert this PR; local fetch continues to write skills without reporting.
Live promotion: no
Autonomous evaluator self-editing: no
Self-check
src/gep/skillInstallSuccess.jsfollows sibling plain-source gep client modules (no public.manifest in this package layout)