[pull] master from beyond-all-reason:master - #85
Merged
Conversation
* Parse the DX10 extended header in nv_dds DDS files written with a DX10 extended header (texconv and modern compressors emit these) were rejected outright. Read the extended header, honour its cubemap/volume resource dimensions, and map DXGI_FORMAT_BC1/BC2/BC3_UNORM onto the already-supported S3TC formats. Texture arrays (arraySize > 1) are rejected. * Load BC4, BC5 and BC7 compressed DDS textures in nv_dds Map the legacy ATI1/BC4U and ATI2/BC5U FourCCs plus the DXGI BC4_UNORM, BC5_UNORM, BC7_UNORM and BC7_UNORM_SRGB formats onto GL_COMPRESSED_RED_RGTC1, GL_COMPRESSED_RG_RGTC2 and GL_COMPRESSED_(SRGB_ALPHA_)BPTC_UNORM. BC4/BC5 blocks reuse the DXT5 alpha block layout so the existing vertical-flip machinery covers them; BC7 blocks cannot be flipped without a full decode, so those files load unflipped with a warning and should be authored pre-flipped. Saving remains restricted to the classic DXT1/3/5 FourCC formats.
The timestamp `ts` can be modified concurrently between its two reads in the original implementation. This caused effectively useless values getting returned by the function.
Spring.ReplaceMouseCursor with a name whose files load no frames silently turns a working cursor invisible, which reads as a rendering bug and cost a debugging session on macOS before the cause surfaced. Warn rather than refuse: content may rely on a frameless replacement to hide the cursor deliberately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )