fix: add getSnapshot memoizedShallowEqual to skip rerenders - #97952
Draft
LukasMod wants to merge 1 commit into
Draft
fix: add getSnapshot memoizedShallowEqual to skip rerenders#97952LukasMod wants to merge 1 commit into
LukasMod wants to merge 1 commit into
Conversation
Contributor
|
|
42 tasks
Contributor
|
Hi @LukasMod can you merge main and I'll regen builds for QA testing |
LukasMod
force-pushed
the
fix/onyx-selector-new-subscriber
branch
2 times, most recently
from
August 11, 2026 09:55
5ab59fd to
53c21e4
Compare
LukasMod
force-pushed
the
fix/onyx-selector-new-subscriber
branch
from
August 11, 2026 10:32
53c21e4 to
2db69aa
Compare
Contributor
Author
|
@Julesssss Rebased today 👍 |
Contributor
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
Requested testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Related to Expensify/react-native-onyx#819
Fixed Issues
$ #95584
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari