Repository navigation
Bump node-forge to 1.4.2 - #136
Merged
Merged
Conversation
Co-authored-by: Ionatan Wiznia <iwiznia@users.noreply.github.com>
iwiznia
approved these changes
Nov 2, 2026
iwiznia
marked this pull request as ready for review
November 2, 2026 16:46
amyevans
approved these changes
Nov 2, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Bumps transitive
node-forge1.4.0 → 1.4.2 inpackage-lock.jsonandapps/expo-example/package-lock.json. Parents already allow^1.3.3, so only the lockfiles change.Why: Dependabot alerts 320 and 117 (GHSA-86w9-cpqp-85rv) still flag 1.4.0. The 1.4.0 fix for RSA PKCS#1 v1.5 signature forgery was incomplete. Upstream fixed it in 1.4.1 (tracked upstream as GHSA-2g46-22mc-6gwp). 1.4.2 fixes a 1.4.1 regression in
pem.decode()forBufferinput. GitHub's advisory still lists no patched version, so the alerts may need to be dismissed as fixed after this merges.Usage: Not imported by the library. It's a transitive dep of
@expo/cli(viaexpo-module-scriptsat root,expoinexpo-example). Not shipped in the published package.Heads-up:
.npmrcsetsmin-release-age=7. 1.4.2 was published 2026-10-27 14:09 UTC, so npm may refuse to resolve it before 2026-11-03 14:09 UTC. The lockfiles were edited directly for that reason.Change Log
1.4.2 (changelog)
pem.decode()converts non-string input to a string again (1.4.1 regression).1.4.1
Related Issues
$ https://github.com/Expensify/Expensify/issues/695834
Manual Tests
No unit tests: lockfile-only bump. Verified with
npm ls node-forge --package-lock-only(root andapps/expo-example) that both resolve to 1.4.2. node-forge has no dependencies, so no other lockfile entries change.// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
Linked PRs