Skip to content

chore(core): remove review skill - #34

Merged
factory-nizar merged 1 commit into
masterfrom
nizar/rm-core-review
Jul 30, 2026
Merged

chore(core): remove review skill#34
factory-nizar merged 1 commit into
masterfrom
nizar/rm-core-review

Conversation

@factory-nizar

@factory-nizar factory-nizar commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Removes the review skill from the core plugin and its derived references.

Why

The CLI ships its own review skill as a builtin (apps/cli/builtin-skills/review/SKILL.md). The core plugin in this marketplace also ships a review skill. Because the marketplace install lands in UserPlugin (priority 9) and the CLI builtin lands in Builtin (priority 11) per apps/cli/src/skills/constants.ts's SKILL_BUCKET_PRIORITY, the marketplace copy shadows the CLI builtin on name collision. The result is that review does not appear in the Skills panel's Built-in tab (the snapshot in the local marketplace clone was also stale/dirty relative to master, making the rendered marketplace view inconsistent).

This PR deletes the marketplace copy so the CLI's authoritative, versioned builtin is the source of truth.

Changes

  • delete plugins/core/skills/review/SKILL.md and the now-empty plugins/core/skills/review/ directory
  • delete the skills/review top-level symlink it produced
  • drop the review bullet from the core plugin's Skills section in README.md
  • drop the /review row from the slash-command table in plugins/droid-control/skills/droid-cli/SKILL.md

Untouched (intentionally)

  • the simplify, init, and session-navigation skills under core stay
  • marketplace.json only references the core plugin by name (not individual skills), so no edits needed there
  • the local CLI builtin at apps/cli/builtin-skills/review/SKILL.md is untouched; BUILTIN_REVIEW_SKILL in apps/cli/src/skills/builtin/builtinSkillDefinitions.ts continues to ship

Diff stat

4 files changed, 254 deletions(-)

No Linear ticket — purely a marketplace cleanup.

The core plugin ships a `review` skill that duplicates the CLI builtin
shipped at apps/cli/builtin-skills/review/SKILL.md and shadows it via the
UserPlugin > Builtin bucket ordering, hiding it from the UI's Built-in tab.
Drop the marketplace copy, the top-level skills/review symlink, the
reference in README.md, and the /review slash-command row in the
droid-cli skill's slash command table.
factory-ain3sh
factory-ain3sh previously approved these changes Jul 30, 2026
@factory-nizar
factory-nizar merged commit e3ff29f into master Jul 30, 2026
2 checks passed
@factory-nizar
factory-nizar deleted the nizar/rm-core-review branch July 30, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants