chore(core): remove review skill - #34
Merged
Merged
Conversation
The core plugin ships a `review` skill that duplicates the CLI builtin shipped at apps/cli/builtin-skills/review/SKILL.md and shadows it via the UserPlugin > Builtin bucket ordering, hiding it from the UI's Built-in tab. Drop the marketplace copy, the top-level skills/review symlink, the reference in README.md, and the /review slash-command row in the droid-cli skill's slash command table.
factory-ain3sh
previously approved these changes
Jul 30, 2026
factory-nizar
force-pushed
the
nizar/rm-core-review
branch
from
July 30, 2026 21:39
8300dcf to
4dde2e3
Compare
factory-ain3sh
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
reviewskill from thecoreplugin and its derived references.Why
The CLI ships its own
reviewskill as a builtin (apps/cli/builtin-skills/review/SKILL.md). Thecoreplugin in this marketplace also ships areviewskill. Because the marketplace install lands inUserPlugin(priority 9) and the CLI builtin lands inBuiltin(priority 11) perapps/cli/src/skills/constants.ts'sSKILL_BUCKET_PRIORITY, the marketplace copy shadows the CLI builtin on name collision. The result is thatreviewdoes not appear in the Skills panel's Built-in tab (the snapshot in the local marketplace clone was also stale/dirty relative tomaster, making the rendered marketplace view inconsistent).This PR deletes the marketplace copy so the CLI's authoritative, versioned builtin is the source of truth.
Changes
plugins/core/skills/review/SKILL.mdand the now-emptyplugins/core/skills/review/directoryskills/reviewtop-level symlink it producedreviewbullet from thecoreplugin's Skills section inREADME.md/reviewrow from the slash-command table inplugins/droid-control/skills/droid-cli/SKILL.mdUntouched (intentionally)
simplify,init, andsession-navigationskills undercorestaymarketplace.jsononly references thecoreplugin by name (not individual skills), so no edits needed thereapps/cli/builtin-skills/review/SKILL.mdis untouched;BUILTIN_REVIEW_SKILLinapps/cli/src/skills/builtin/builtinSkillDefinitions.tscontinues to shipDiff stat
No Linear ticket — purely a marketplace cleanup.