docs(code-review): steer model selection to review_depth presets - #41
Closed
factory-nizar wants to merge 3 commits into
Closed
factory-nizar wants to merge 3 commits into
factory-nizar wants to merge 3 commits into
Conversation
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
…g them Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
…model Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Contributor
Author
|
Closing: the docs moved to factory-public-web. These changes are now in https://github.com/Factory-AI/factory-public-web/pull/698. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of AUT-2375
Why
Many Droid code review workflows pin a specific model through
review_model, so they stay on old models (about a fifth of reviews still run on GPT-5.2). The review presets are about to track Factory's recommended models automatically (Factory-AI/droid-action#144, backed by the tier aliases in Factory-AI/factory-mono#22502). The docs should push people toward the presets and away from pinning models.What
review_depth(deep/shallow) as the only model setting most teams need, explains that presets follow Factory's recommended model, notes thatdeepis what the Factory team uses (a hand-picked, strong balanced model with high reasoning), and tells users with older setups to removereview_model,security_model, andreasoning_effort. A new "Advanced: model overrides" subsection, opened by a warning that most teams should skip it, documents the override inputs, lists provider tier aliases (openai-,anthropic-,oss-latest-premium/balanced/fast), withopenai-latest-premium/anthropic-latest-balancedas the example, and discourages exact model IDs.droid exec --model claude-sonnet-4-5-20250929and does not match how droid-action workflows are configured.review_modelandreasoning_effortare labeled "Advanced" and link to the overrides subsection.security_modelis labeled "Advanced", notes that PR security reviews followreview_depthwhen it is empty, and links to the overrides subsection.Japanese pages are left to the
sync-jp-docsworkflow.Rollout
Merge together with (or after) the droid-action release that includes Factory-AI/droid-action#144. The tier aliases need a Droid CLI release that includes Factory-AI/factory-mono#22502.
Testing
npx mint broken-linksfromdocs/: no broken links (this also parses the changed MDX).