chore: repin zccache to main b385a7b (post-1.14.14 perf work) - #1573
Merged
Merged
Conversation
Picks up zccache's cache-hit and daemon performance work since 9bc8b4d: heartbeat-free compile requests (#1768, ~3.7x faster warm hits), no per-header mtime-floor stats on C/C++ hits (#1770), dropped durability syncs on depfile rewrites and hardlink detach copies (#1761, #1763), faster shutdown polling and unchanged-state skip (#1762, #1775), plus staging/error-cache fixes (#1796, #1795). running-process stays =4.10.14 (zccache's resolved version), so the dep-identity lockstep holds.
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: FastLED/fbuild/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repins the embedded zccache git dependency from
9bc8b4dtob385a7b, zccachemain: 23 commits. The version string is still 1.14.14.What it brings, performance-wise
Fixes included: a staging-root race (#1796), no caching of rustc failures caused by OS errors (#1795), and
AUTOmaterialization now means reflink-else-copy (#1792).Change: the
revin the five crates that pin zccache; the pin comment infbuild-build/Cargo.toml;Cargo.lock(only zccache's 14 crates move; some now use the already-presentwindows-sys0.61).running-processstays=4.10.14, the version zccache resolves, so the dependency-identity lockstep test passes.Verification (local)
dep_identitypasses.fbuild-build-engine479,-esp144,-mcu77,fbuild-library297,fbuild-daemon288.Before/after benchmark numbers (cold, cache-hit and incremental builds) will be posted as a comment.