return null from nextStringValue() at end of input - #899
Open
Sahana2524 wants to merge 1 commit into
Open
Conversation
🧪 Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nextStringValue() runs the XmlTokenStream event through a switch, but the XML_END branch has no break and falls into the default: case that throws. So one call past the last token raises an unchecked exception instead of reporting end-of-input as null, the way nextToken() already does for XML_END. Callers that only catch JacksonException do not see it.
Added the missing break so the XML_END case reaches the method's shared
return null. Extended the existingXmlParserNextXxxTestwith one call past the end, which throws on the current tree and now returns null.