Repository navigation
Fix #800: Upgrade ion-java to 1.12.1 (from 1.11.11) - #801
Merged
Merged
Conversation
1.11.11 carries a binary-write corruption bug (amazon-ion/ion-java#1150): stale `PatchPoint`s in `IonRawBinaryWriter` produce invalid Ion binary when a writer is flushed or finished and then written to again. Fixed in 1.12.0. 1.12.1 is still Java 8 bytecode, so no baseline change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
🧪 Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #800.
Bumps
ion/pom.xmlfromion-java1.11.11 to 1.12.1.Why
1.11.11 is the one release carrying a binary-write corruption bug, fixed in 1.12.0 by amazon-ion/ion-java#1150: stale
PatchPoints inIonRawBinaryWriterget applied on a subsequentfinish(), producing invalid Ion binary. It triggers on binary writers with container length preallocation (1 byte by default) when the writer is flushed or finished and then written to again.Jackson's own generator paths do not appear to trigger it —
IonGenerator.flush()flushes the destination rather than theIonWriter, and nothing callsfinish()— so the exposure is to callers passing their ownIonWritertoIonFactory.createGenerator(ObjectWriteContext, IonWriter). Still not a version to stay pinned to.Also picked up: incremental reader buffer growth instead of allocating the full declared length up front, text read optimizations, and GZIP auto-decompression changes (new
IonReaderBuilder.withGzipDecompressionEnabledopt-out, plus removal of a second auto-decompression layer).Compatibility
1.12.1 is still Java 8 bytecode (
major version: 52, OSGiRequire-Capability: JavaSE 1.8), so this is not a baseline change — it would be viable on the 2.x branches too, which pin the same 1.11.11../mvnw verifyin theionmodule: 265 tests, 0 failures.🤖 Generated with Claude Code