test: push payload assertions accept either callback order - #24
Merged
Conversation
Both registration timestamp orders exercise exact full-event and ID-only payload matching while preserving delivery counts and callback identity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The push payload test assumed its third callback was ID-only. Registration timestamps can reverse the two callbacks, causing a failure even when both deliveries are correct.
Change
Match the second event's deliveries by event ID and exact payload content, preserving total counts, callback URL, normalized relay URL, complete-event content and ID-only privacy assertions. Parameterized fixtures make the ID-only registration older and newer than the full-event registration. Only
test/object/push.test.tschanges; production behavior is unchanged.Testing Completed
npm run typecheckpasses, including generated-file, console and configuration checks.npm test -- --maxWorkers=1: 49 files, 253 tests pass.Responsible AI disclosure
Codex authored and validated this test-only follow-up. Human review is requested; no merge or deployment was performed.