Skip to content

ci: drop the renovate rebase dispatch - #1078

Merged
BryanFRD merged 1 commit into
mainfrom
ci/drop-renovate-rebase
Sep 17, 2026
Merged

BryanFRD merged 1 commit into
mainfrom
ci/drop-renovate-rebase

Conversation

@BryanFRD

Copy link
Copy Markdown
Contributor

Renovate now runs as a CronJob in the cluster (FerrLabs/Infra#424), and FerrLabs/.github#339 removes renovate.yml and reusable-renovate-dispatch.yml. The "rebase now" dispatch has nothing left to trigger: a ticked checkbox is handled by the next in-cluster run (every 2 h).

Merge after FerrLabs/.github#339.

@ferrfleet ferrfleet Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean deletion. Nothing else in the repo references renovate-rebase.yml or reusable-renovate-dispatch.yml, and renovate.json only extends the org preset, so it is unaffected. The merge-order note is a safety margin rather than a requirement: the uses: line pins the reusable workflow by SHA, so it would keep resolving even if FerrLabs/.github#339 lands first.

Nit (outside this diff, but the same migration): .github/workflows/ci.yml gates the advisory cargo vet path on github.event.pull_request.user.login == 'ferrlabs-renovate[bot]'. If the in-cluster CronJob authenticates as anything other than that same App, the condition stops matching and lockfile-only PRs get the hard vet gate back. That fails closed, so it is not a security problem, just weekly noise on a required check. Worth confirming the cluster Renovate uses the same App credentials.

@github-actions

Copy link
Copy Markdown

SonarQube — aucune nouvelle issue

Comparaison entre le projet bac à sable de cette PR et la branche par défaut : SonarQube Community n'analyse pas les PR, ce delta est calculé côté CI. Détail

@BryanFRD
BryanFRD merged commit 26bb995 into main Sep 17, 2026
30 checks passed
@BryanFRD
BryanFRD deleted the ci/drop-renovate-rebase branch September 17, 2026 06:18
@BryanFRD

Copy link
Copy Markdown
Contributor Author

On the cargo vet gate: the in-cluster Renovate authenticates as the same GitHub App and sets the same author (ferrlabs-renovate[bot], FerrLabs/Infra#424), so the login check in ci.yml keeps matching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant