Skip to content

Write down the fact-fixing workflow - #893

Merged
Firehed merged 2 commits into
mainfrom
process/fix-a-fact
Nov 2, 2026
Merged

Firehed merged 2 commits into
mainfrom
process/fix-a-fact

Conversation

@Firehed

@Firehed Firehed commented Oct 30, 2026

Copy link
Copy Markdown
Owner

Writes down, in the repository, the way of working that fixed member access (#882), class edges (#888), trait and inheritance composition (#890) and trait alias modifiers (#892) without leaving partial routes behind. Until now it lived only in one session's history and in per-user memories, which other agents and sessions do not reliably see.

Changes

  • New skill fix-a-fact (.claude/skills/fix-a-fact/SKILL.md): the workflow for any change to what the server says about code.

    1. State the fact and PHP's real behavior, asking which to follow when PHP versions differ.
    2. Find every route from a closed set of files and read them all.
    3. Write a short design and have fresh agents attack it against the two rules (do what PHP does; one route per fact) until a round finds nothing; fix lower-level facts first, in their own pull request.
    4. Build test-first against an oracle where one exists, reusing fixtures.
    5. Review with pr-review and an adversarial "who else decides this fact" pass; fix findings in the pull request's own code fully; track the rest as issues or known-defect scripts.

    It includes the two adversarial prompts, since their wording mattered.

  • pr-review gains a fourth pass, remaining routes: code anywhere in src/ that still decides a fact the pull request claims to own. In this session that pass found a route a general review missed.

  • AGENTS.md gains always-on rules: the fix-a-fact workflow for changes to what the server says, fixing at the root instead of patching symptoms, pull request descriptions written for a reader with no context and without php-src citations, and answering broken-code questions from the parser's guarantees rather than from how recovery works.

The pr-review change landed in the AGENTS.md commit; the squash merge makes that moot.

🤖 Generated with Claude Code

Firehed and others added 2 commits October 29, 2026 17:57
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.70%. Comparing base (c82b088) to head (639f048).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #893   +/-   ##
=========================================
  Coverage     99.70%   99.70%           
  Complexity     1970     1970           
=========================================
  Files           147      147           
  Lines          4481     4481           
=========================================
  Hits           4468     4468           
  Misses           13       13           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Firehed
Firehed marked this pull request as ready for review November 2, 2026 17:28
@Firehed
Firehed merged commit 44f6a1f into main Nov 2, 2026
8 checks passed
@Firehed
Firehed deleted the process/fix-a-fact branch November 2, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant