Repository navigation
Write down the fact-fixing workflow - #893
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
=========================================
Coverage 99.70% 99.70%
Complexity 1970 1970
=========================================
Files 147 147
Lines 4481 4481
=========================================
Hits 4468 4468
Misses 13 13 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writes down, in the repository, the way of working that fixed member access (#882), class edges (#888), trait and inheritance composition (#890) and trait alias modifiers (#892) without leaving partial routes behind. Until now it lived only in one session's history and in per-user memories, which other agents and sessions do not reliably see.
Changes
New skill
fix-a-fact(.claude/skills/fix-a-fact/SKILL.md): the workflow for any change to what the server says about code.pr-reviewand an adversarial "who else decides this fact" pass; fix findings in the pull request's own code fully; track the rest as issues or known-defect scripts.It includes the two adversarial prompts, since their wording mattered.
pr-reviewgains a fourth pass, remaining routes: code anywhere insrc/that still decides a fact the pull request claims to own. In this session that pass found a route a general review missed.AGENTS.md gains always-on rules: the
fix-a-factworkflow for changes to what the server says, fixing at the root instead of patching symptoms, pull request descriptions written for a reader with no context and without php-src citations, and answering broken-code questions from the parser's guarantees rather than from how recovery works.The pr-review change landed in the AGENTS.md commit; the squash merge makes that moot.
🤖 Generated with Claude Code