Skip to content

feat: wire up the edge_proxy private app - #8305

Draft
gagantrivedi wants to merge 1 commit into
mainfrom
feat/edge-proxy-app-wiring
Draft

feat: wire up the edge_proxy private app#8305
gagantrivedi wants to merge 1 commit into
mainfrom
feat/edge-proxy-app-wiring

Conversation

@gagantrivedi

Copy link
Copy Markdown
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to Flagsmith/edge-proxy#128

Wires up the edge_proxy private app (Flagsmith/flagsmith-private#265), which adds the credential and inventory endpoint that let a running Edge Proxy discover environments itself.

Three edits, following the rbac/scim pattern:

  • EDGE_PROXY_INSTALLED detection and conditional INSTALLED_APPS append.
  • Mounts for the two URL trees: proxy key management under organisations/{id}/edge-proxy/, and api/v1/proxy/ for the inventory endpoint.
  • A mypy override so the no-private run passes.

The feature is for self-hosted and private cloud only. SaaS images ship the private wheel, so the mount is gated on is_saas() at runtime rather than on the app being absent; the app's own views carry a matching permission as defence in depth.

The flagsmith-private lock bump follows once #265 is released — the current pin (>=0.11.4,<1) already allows it, and without a wheel containing edge_proxy these mounts are inert.

How did you test this code?

Against a checkout with flagsmith-private installed editable from the #265 branch:

  • Both URL trees resolve (/api/v1/organisations/1/edge-proxy/keys/, /api/v1/proxy/config/).
  • With a SAAS_DEPLOYMENT marker file present, they 404 — reverse() raises NoReverseMatch.
  • django-admin check reports no new issues.

The app's own behaviour is covered by 15 integration tests in #265.

Detects the edge_proxy app and mounts its two URL trees: proxy key
management for organisation admins, and the environment inventory that
Edge Proxy instances poll.

The feature is for self-hosted and private cloud only. SaaS images ship
the private wheel, so the mount is gated on is_saas() at runtime rather
than on the app being absent; the app's own views carry a matching
permission as defence in depth.
@vercel

vercel Bot commented Aug 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Aug 15, 2026 10:34am
flagsmith-frontend-preview Ignored Ignored Aug 15, 2026 10:34am
flagsmith-frontend-staging Ignored Ignored Aug 15, 2026 10:34am

Request Review

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 078cddbc-3c82-42b7-b80e-2ba8427c9f6a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added api Issue related to the REST API feature New feature or request labels Aug 15, 2026
@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.78%. Comparing base (a013d7b) to head (42c4d60).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8305   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files        1604     1604           
  Lines       64335    64336    +1     
=======================================
+ Hits        63551    63552    +1     
  Misses        784      784           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant