feat(__future__): Delete a flag's segment override by khvn26 · Pull Request #8307 · Flagsmith/flagsmith

khvn26 · 2026-08-15T13:36:52Z

I have read the Contributing Guide.
I have added information to docs/ if required so people know about the feature.
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.

Changes

Adds DELETE /api/__future__/environments/{environment_key}/features/{feature_id}/segment-overrides/{segment_id}/, so a caller can remove one segment override without sending the whole list back through PUT.

Behaviour follows the sibling verbs:

MANAGE_SEGMENT_OVERRIDES gates it. A caller with no permission on the environment gets 404; one holding only UPDATE_FEATURE_STATE gets 403.
409 where change requests are enabled, logging features.flag.update_rejected.
404 for non-existing segment overrides.
Versioning-agnostic.
Remaining overrides keep their priorities.

Updated documentation: https://docs-git-feat-update-flag-delete-flagsmith.vercel.app/managing-flags/updating-flags

How did you test this code?

Added integration tests.

vercel · 2026-08-15T13:36:55Z

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs	Ignored	Preview	Aug 16, 2026 2:37pm
flagsmith-frontend-preview	Ignored	Preview	Aug 16, 2026 2:37pm
flagsmith-frontend-staging	Ignored	Preview	Aug 16, 2026 2:37pm

coderabbitai · 2026-08-15T13:37:15Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: dd036277-80a6-4162-b6f0-9bd3c684c04c

📥 Commits

Reviewing files that changed from the base of the PR and between 2ed87a3 and 3219551.

📒 Files selected for processing (2)

api/tests/unit/features/future/__init__.py
api/tests/unit/features/future/test_unit_future_services.py

Included review availability: Your plan includes up to 8 reviews per rolling hour; 6 remain after this review.

📝 Walkthrough

Walkthrough

The change adds an experimental DELETE endpoint for one segment override. The endpoint authenticates requests, checks permissions, validates workflow restrictions, and deletes the override transactionally. Enabled environments publish a new version. The response contains the updated flag state. Integration and query-count tests cover deletion, errors, permissions, workflows, versions, logs, and state preservation. OpenAPI, user documentation, and event catalogue references are updated.

Estimated code review effort: 4 (Complex) | ~45 minutes

Merge Risk: ⚪ Minimal · up to 32195

This PR adds a localized endpoint for deleting a single segment override, with documented permission and error behavior; no actionable merge-blocking risk remains beyond normal checks and review.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-15T13:37:55Z

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-e2e:pr-8307`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-api-test:pr-8307`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-frontend:pr-8307`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-api:pr-8307`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-8307`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-8307`	Finished ✅	Results ✅

codecov · 2026-08-15T13:43:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.78%. Comparing base (a013d7b) to head (6bb85dc).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8307   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files        1604     1604           
  Lines       64335    64426   +91     
=======================================
+ Hits        63551    63642   +91     
  Misses        784      784

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-08-15T13:44:22Z

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19445 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

3 passed

Details

3 tests across 3 suites
39.5 seconds
6bb85dc
🔄 Run: #19445 (attempt 1)

🗂️ Previous results

✅ private-cloud · depot-ubuntu-latest-16 — run #19445 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

2 passed

Details

2 tests across 2 suites
32.9 seconds
6bb85dc
🔄 Run: #19445 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #19445 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
45.6 seconds
6bb85dc
🔄 Run: #19445 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #19445 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
34.5 seconds
6bb85dc
🔄 Run: #19445 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19442 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

3 passed

Details

3 tests across 3 suites
37.5 seconds
3219551
🔄 Run: #19442 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #19442 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

2 passed

Details

2 tests across 2 suites
47.6 seconds
3219551
🔄 Run: #19442 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #19442 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
45.4 seconds
3219551
🔄 Run: #19442 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #19442 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
34.6 seconds
3219551
🔄 Run: #19442 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19434 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
37.6 seconds
2ed87a3
🔄 Run: #19434 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #19434 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

3 passed

Details

3 tests across 3 suites
32.6 seconds
2ed87a3
🔄 Run: #19434 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #19434 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
46.8 seconds
2ed87a3
🔄 Run: #19434 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #19434 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
41.3 seconds
2ed87a3
🔄 Run: #19434 (attempt 1)

github-actions · 2026-08-15T13:45:30Z

Visual Regression

19 screenshots compared. See report for details.
View full report

Flagsmith/flagsmith#8307 adds `DELETE …/features/{id}/segment-overrides/{segment_id}/`, so removing one override no longer means replacing the whole set. That takes the read-modify-write out of `flag delete --segment`: the surviving overrides are neither read nor restated, so a concurrent change to one can't be lost, and the endpoint's answer is the whole flag, as it is for the writes. `echoOverrides` and `echoVariants` go with it — restating an override's weights only mattered because a replacing write inherits the environment default's when `variants` is omitted. The override rows are still read, for two reasons a 404 doesn't cover: the prompt names the segment, and a segment with no override should be caught before asking rather than after.

emyller · 2026-08-16T13:17:15Z

Left a couple non-blocking comments.

This reverts commit 3219551.

emyller

LGTM

feat(__future__): Delete a flag's segment override

377d165

khvn26 requested review from a team as code owners August 15, 2026 13:36

khvn26 requested review from bakirFS and emyller and removed request for a team August 15, 2026 13:36

github-actions Bot added api Issue related to the REST API docs Documentation updates labels Aug 15, 2026

vercel Bot deployed to Preview – docs August 15, 2026 13:37 View deployment

github-actions Bot removed the docs Documentation updates label Aug 15, 2026

github-actions Bot added the feature New feature or request label Aug 15, 2026

khvn26 mentioned this pull request Aug 15, 2026

feat: Migrate to the new update-flag contract, and flag update --weight Flagsmith/flagsmith-cli#92

Merged

emyller reviewed Aug 15, 2026

View reviewed changes

Comment thread api/tests/integration/features/future/test_flag_endpoint.py Outdated

khvn26 mentioned this pull request Aug 15, 2026

chore(__future__): Drop the AnonymousUser asserts and the strict log assertions #8308

Merged

4 tasks

test(__future__): Keep the fixtures together

4b36fdd

github-actions Bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Aug 16, 2026

emyller previously approved these changes Aug 16, 2026

View reviewed changes

Comment thread api/features/future/services.py

Comment thread api/tests/integration/features/future/test_flag_endpoint.py Outdated

test(__future__): Drop the redundant last-override case

2ed87a3

khvn26 dismissed emyller’s stale review via 2ed87a3 August 16, 2026 13:32

github-actions Bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Aug 16, 2026

test(__future__): Pin the query counts a flag write makes

3219551

github-actions Bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Aug 16, 2026

Revert "test(__future__): Pin the query counts a flag write makes"

6bb85dc

This reverts commit 3219551.

github-actions Bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Aug 16, 2026

emyller approved these changes Aug 16, 2026

View reviewed changes

khvn26 merged commit b3b2b31 into main Aug 16, 2026
35 checks passed

khvn26 deleted the feat/update-flag-delete branch August 16, 2026 15:38

flagsmith-engineering Bot mentioned this pull request Aug 14, 2026

chore(main): release 2.263.0 #8267

Open

Uh oh!

Conversation

khvn26 commented Aug 15, 2026

Changes

How did you test this code?

Uh oh!

vercel Bot commented Aug 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

github-actions Bot commented Aug 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docker builds report

Uh oh!

codecov Bot commented Aug 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Aug 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Uh oh!

github-actions Bot commented Aug 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual Regression

Uh oh!

Uh oh!

Uh oh!

Uh oh!

emyller commented Aug 16, 2026

Uh oh!

emyller left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Aug 15, 2026 •

edited

Loading

coderabbitai Bot commented Aug 15, 2026 •

edited

Loading

github-actions Bot commented Aug 15, 2026 •

edited

Loading

codecov Bot commented Aug 15, 2026 •

edited

Loading

github-actions Bot commented Aug 15, 2026 •

edited

Loading

github-actions Bot commented Aug 15, 2026 •

edited

Loading