fix(proof): lock paging-only has_more after review - #257
Merged
tonyketcham merged 1 commit intoAug 22, 2026
Conversation
Addresses the 19 Aug / 22 Aug grouped notes on #254. - CHANGELOG: page.has_more is pagination-only; use cap_reasons for walls - Both reference.md copies: page only when has_more; hard caps need a narrower query - CLI spawn: assert next_cursor on page-only, null on bytes, summary co-list - Digest unit: paging plus displayed_edges; refuse hasMore without a cursor - renderDigest: has_more requires a non-empty nextCursor Change-Id: I4023a95677e42aee745e3a2e6748852cb8ea1af3 Co-authored-by: Tony <tonyketcham@users.noreply.github.com>
tonyketcham
marked this pull request as ready for review
August 22, 2026 16:59
tonyketcham
merged commit Aug 22, 2026
be2cece
into
stack/toeknee-figma/fix/proof-read-completeness/expose-read-completeness--4cbd9019
22 checks passed
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Addresses the open 19 Aug notes grouped in PR 254 review 5000573079. One subagent owned each group.
page.has_moreis pagination-only. Usecap_reasons/completefor hard caps.primary_recordsstays an in-process signal after the CLI slice.reference.mdcopies — page only whenpage.has_more. Hard caps that paging cannot clear mean narrow the query or fail closed.proof list --limit 1now asserts a non-nullnext_cursor. The bytes path asserts a null cursor. Relationssummarynames bothdisplayed_edgesandpagination.renderDigestwith a hard cap and a cursor. Also refuseshasMorewithout a cursor.renderDigestsetshas_moreonly whenhasMoreis true andnextCursoris a non-empty string. It does not OR the 25-record wall back intohas_more.Related #254. The parent PR already closes #252.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Does this introduce any non-backwards compatible changes?
Does this include any user config changes?
Local test evidence
Digest suite: 13 passed, including paging plus
displayed_edgesand refuse-hasMore-without-cursor. CLI completeness spawn: 1 passed. Full@flatbread/proofava suite: 124 passed.skills:checkand Prettier on the touched files passed.proof_completeness_review_tests.log