docs(proof): journal paging-only has_more as the product rule - #258
Merged
tonyketcham merged 1 commit intoAug 22, 2026
Conversation
The 22 Aug review of #254 asked to record that page.has_more is pagination-only, not a five-file split, and to stop using Issue kind on the Finding. Co-authored-by: Cursor <cursoragent@cursor.com> Change-Id: I18e831209621f3373523f5c0b2aa3acceafed031
tonyketcham
merged commit Aug 22, 2026
55673a2
into
stack/toeknee-figma/fix/proof-read-completeness/expose-read-completeness--4cbd9019
21 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Addresses the two open 22 Aug journal-quality notes on #254. No envelope code changed.
gapis superseded by aretrospectiveFinding. The gap itself is now Issueiss-pr-254-journal-used-issue-kind-on-a-finding-and--9p7t7amz79y5rn3b.dec-treat-page-has-more-as-pagination-only--dv24ta688adf262vstates the product rule as the Choice (page.has_moreis pagination-only; unpairedhasMoreis refused; hard caps stay oncomplete/cap_reasons). The five-file split is a note. Accepted withrejectSiblings: false. The prior file-split Decision issuperseded.Related #254.
Test plan
proposedMade with Cursor