fix: skip the link check on image builds, narrow the og-image cache - #213
Merged
Conversation
FlowFuse/website's own test.yml cached two directories under a github.run_id key, so every run wrote a fresh entry. Measured on website main, the entry is 2.5MB, restores in 1s, and 53 of them were live. Build the forge took 1359s with it against 1394s without, so the render directory was buying nothing. This keeps only the font download, keyed on the lockfile that pins the module, so an unchanged lockfile hits exactly and saves nothing back.
5 tasks
dimitrieh
changed the title
Contributor
Author
|
Added a second fix here rather than opening another pull request, since it touches the same file. With |
ppawlowski
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to Website preview on documentation pull requests.
Two fixes to the shared build, both surfaced by FlowFuse/website#5515 calling it instead of running its own steps.
og-image cache. FlowFuse/website#5562 keyed it on
github.run_id, so it wrote a fresh entry every run. Only the font download is worth keeping, so this caches that one directory keyed on the lockfile that pins the module. Measured on websitemain, it saves about 35s and the entry is 2.5 MB.Link check. With
deploy_previewset, Nuxt Image points every<img>at/.netlify/images, which Netlify only answers at runtime, so hyperlink reads every image as a broken link and cannot be told to ignore the path. The check now runs on the builds that keep real file paths. This is what fails FlowFuse/flowfuse#8070 today.fix:cuts a patch and force-movesbuild_website/v1, so neither caller needs a ref change.