Conversation
sinthu-14
marked this pull request as ready for review
September 25, 2026 12:14
ForNeVeR
self-requested a review
September 25, 2026 19:58
… / can't resolve the new relative path on another drive
ForNeVeR
force-pushed
the
feature/95.forbid-construction-of-incorrect-absolute-paths
branch
from
October 4, 2026 20:45
2201c55 to
8d35cf3
Compare
…s, Parent gating, docs - AbsolutePathTests: resolve against a fresh temporary subdirectory, so the cross-drive test doesn't depend on TEMP having a parent. - AbsolutePathTests: fold the duplicated Unix/Windows constructor theories into cross-platform ones built on the synthetic root. - LocalPath.Parent: only check for a trailing ".." in relative paths, since the normalization drops a ".." directly after the root. - Update the normalization docs and the stale comment in PathStrings.
…per-segment allocations - Return the rented buffer when the path normalizes to an empty path or a bare drive, too; previously, these early exits skipped it. - Compare ".." followed by a separator against preallocated strings instead of interpolating them for every segment. - Remove a no-op Slice call.
Owner
|
After some thoughts, I decided to change my decision and normalize |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #95
An exception is thrown now, if the passed string matches the dot-dot directory directly after root (e.g. C:/../ or /../).