Skip to content

Per-code reply macros come from the contract, and PHD_* verb aliases go (review #2, #3) #176

Closed

Description

@linuxnow

protocol.h:266-296 and omx-clap-core src/host_verbs.h:59-63 both define the reply codes by hand. omx-contract render/verbs.mjs emits OMX_REPLY__RESP; drop the defines in both. Render omx-clap-core's installed package into plugin-hostd and remove the PHD_VERB_TRACK_INFO, note-channel, string-max, page-slot and track-kind copies.

Found in the duplicates and abstractions review of 2026-10-26 (finding numbers in the title list).

Activity

  1. linuxnow commented on Oct 28, 2026

    @linuxnow
    ContributorAuthor

    Open PR #181 covers the reply numbers and the shared verb words from the rendered contract (omx-contract#159); omx-clap-core#378 (merged) made the shared verbs declare -901. Same job as #131's verb table on the plugin-hostd side: #131 declares the table, this removes the hand-typed copies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important — fix this month

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions