Repository navigation
Install the preset schema with the other schemas, release 0.9.1 (#145) - #146
Merged
Merged
Conversation
protocol/preset.schema.json is the schema the 0.9.0 preset file is checked against, but make install, the spec and debian/plugin-hostd-dev.install carried only protocol.schema.json and probe-output.schema.json, so a downstream generator could not hold to it. Install it as /usr/share/plugin-hostd/preset.schema.json and list it in plugin-hostd-devel and plugin-hostd-dev beside the others. The pkg-config file already exposes the directory as protocoldir. Schema content is unchanged. Refs #145.
The man page FILES section and the README list the schemas installed beside protocol.json, with the preset schema among them. Regenerated with make gen; make check-generated is current. Refs #145.
test-install-schemas runs make install into a scratch DESTDIR with PREFIX=/usr and asserts protocol.schema.json, probe-output.schema.json and preset.schema.json exist under usr/share/plugin-hostd. make test runs it. Sabotaged by commenting out the preset schema install line of install_protocol, it went red: not installed: usr/share/plugin-hostd/preset.schema.json make: *** [Makefile:327: test-install-schemas] Error 1 and green again with the line restored. Refs #145.
Version 0.9.1 in debian/changelog, the spec, both man pages and src/main.c, with the changelog entry for the installed preset schema.
linuxnow
force-pushed
the
cluster/plugin-hostd-145-preset-schema
branch
from
October 24, 2026 14:20
f7b1027 to
4b1bff6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.9.0 preset file is checked against protocol/preset.schema.json, but the schema was not installed, so a downstream generator could not hold to it. It is now installed as /usr/share/plugin-hostd/preset.schema.json with the other two schemas, listed in the spec and in the debian dev package, and named in the man page and the README. The pkg-config file already exposes the directory as protocoldir. A new test, test-install-schemas, runs make install into a scratch DESTDIR and fails when any of the three schemas is missing. The last commit bumps the version to 0.9.1.
Closes #145