Skip to content

Full classifier: read the note sweep, and do not measure an instrument's latency with an impulse it has no input for #79

Open

Description

@linuxnow

What happens. Two gaps between the CLAP prober and classifyPluginHosting:

  1. The note sweep (Qualify instruments by playing them, and add an omx-clap-host / plugin-hostd host profile #72) is folded into the rt-safety verdict document only. The interchange's CLAP block (PluginClapMeasurement, src/measurement/format.ts) does not carry it, so the full classifier can read an instrument suitable under an instrument host (omx-clap-host, jalv) without it ever having been played.
  2. The latency arm sends an impulse into the main audio input. An instrument has none, so the prober records measuredFrames = declaredFrames + 1 (seen on synth.clap: declared 0, measured 1), and clapLatencyReasons refuses it with hosting.clap.latency-mismatch.

Done when. The interchange carries noteSweep and noteSweepReasons feeds the rtSafety dimension of the classifier; an instrument's latency is either measured from a note (onset after a note on at frame 0) or read as unmeasured, never as a mismatch; synth.clap through the prober and the classifier reads suitable under omx-clap-host and unsuitable under openmixer-console.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important — fix this month

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions