Repository navigation
Install the LV2 host probe; drop openmixer's measurer copy - #75
Merged
Merged
Conversation
openmixer has deleted its own measurer and runs this one, so the copy kept to prove the move bit-identical has nothing left to compare against. openmixer#1599
openmixer tests the LV2 plugin it exports with this probe; installed, the console runs the packaged one and keeps no copy of its own. The installed check runs it on a plugin the bundle lacks and wants exit 2. openmixer#1599
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
make -C native install(and so the RPM and DEB) now installslv2_host_probebeside the measurer, added toNATIVE_TOOLSwith its settingOMX_LV2_HOST_PROBE. The parity copy of openmixer's LV2 measurer (native/parity/, 1 256 lines) and its test go.Why: openmixer deletes its own
tools/lv2-host-probe.cand runs the packaged probe on the LV2 plugin it exports (openmixer#1599). openmixer's measurer is already deleted there, so the parity copy has nothing left to prove.Test:
native-install-dirs.test.tsred with the tool declared and not installed, green once the Makefile installs it.make -C native deps all,pnpm lint,pnpm check:generated,pnpm test:pygreen in the openmixer worker image (Fedora 44). vitest: 3 reds there, the same three at main (no libasan, no plugin-hostd daemon, no LV2 path in the container).make installlands four tools; the installed probe on a URI the bundle lacks exits 2.check-installed.shgains that check; it runs in the package CI.Refs FreeMixer/openmixer#1599