Repository navigation
Restate private citations as facts and refuse them in CI - #83
Merged
Merged
Conversation
The native sources, a test name, two header comments and the crash signature notes cited a private issue, a private design path and dated specification file names. Each now states what the value is and why. A private-refs check (tools/private-refs-check.sh, with a self-test that turns each kind of pointer red in each kind of file) runs in CI so they stay out.
Contributor
Author
|
Tracked under umbrella #1609 (going public: private citations). Old parent: no parent. A pull request cannot be a sub-issue, so this comment is the link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of FreeMixer/openmixer#1478.
noteof four crash signature rows, which now say what was found). They are restated the same way; the notes are provenance text and nothing reads them.pnpm run check:private-refsruns both, and CI runs it after the install.Checked in the worker image:
pnpm run lint, the hosting-suitability tests (106), the check and its self-test.Not covered: bare section citations such as "spec §11" name no file and are not matched by the check; about 30 remain in comments.