Repository navigation
publish.yml installs plugin-hostd like ci.yml, from one shared action - #85
Merged
Merged
Conversation
…#84) The tag's 'Build and test' ran the suite without plugin-hostd and its fake worker, so src/pins-file.test.ts failed and v0.10.0 was not published. The native build and the plugin-hostd install are now composite actions under .github/actions/, used by both ci.yml and publish.yml. A test reads both workflows and fails if either stops using them, carries an inline copy, or if the action no longer sets PLUGIN_HOSTD and PLUGIN_HOSTD_FAKE_HOST. publish.yml keeps its OIDC trusted publishing; no token or secret is added.
…ls-hostd # Conflicts: # .github/workflows/ci.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.10.0 tag run failed at 'Build and test': src/pins-file.test.ts needs PLUGIN_HOSTD and PLUGIN_HOSTD_FAKE_HOST, and only ci.yml installed plugin-hostd.
The native build and the plugin-hostd install now live once, as composite actions in .github/actions/, and both workflows use them. src/workflows-agree.test.ts reads both workflows and fails if one drops an action, keeps an inline copy, or if the install action stops setting the two variables or checking the 0.2.0 floor. It also pins publish.yml to OIDC (no token or secret).
I broke each of those in turn (removed the action line from publish.yml, deleted a variable from the action, put the native build back inline in ci.yml), saw the test go red each time, and restored.
Closes #84. A new tag is needed afterwards: the failed v0.10.0 run does not re-run with this change.