Repository navigation
[xExtension-YouTube] Add an option to disable embedding videos - #557
Merged
Merged
Conversation
Some users enable the extension only for its other features, such as automatically using the channels' icons or converting channel and user URLs to feed URLs, and prefer to keep the original feed content instead of an embedded player. Add an "Embed videos in articles" checkbox to the configuration page, stored in the `yt_embed_videos` user attribute. When it is unchecked, the `entry_before_display` hook leaves YouTube and PeerTube entries untouched. The option defaults to enabled when the attribute is unset, so existing installations keep their current behaviour. Add translations for all supported languages and bump the extension version to 1.4.0. Fixes FreshRSS#517
Member
|
Thanks. And indeed there are a couple of merge conflicts. Please fix (you can just continue pushing to the same branch; no git rewrite needed) |
Signed-off-by: NopeCharon <115794254+NopeCharon@users.noreply.github.com> # Conflicts: # xExtension-YouTube/README.md # xExtension-YouTube/metadata.json
Contributor
Author
|
Merged main into the branch and fixed the conflicts, keeping version 1.4.0 with the 1.3.2 changelog entry below it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yt_embed_videosuser attribute)entry_before_displayhook leaves YouTube and PeerTube entries untouched, while the other features (channel icons, channel/user URL to feed URL conversion) keep workingFixes #517
Behavior
yt_embed_videosValidation
edgewith a realFreshRSS_UserConfiguration: checkedembedYouTubeVideo()forwatch?v=,shorts/and PeerTube links with the setting unset /true/false, renderedconfigure.phtml(checkbox checked by default and when enabled, unchecked when disabled), and saved the form throughhandleConfigureAction()with and without the checkboxcomposer run-script php-lint,composer run-script phtml-lint,phpcs,phpstan(with../FreshRSS)markdownlint-cli2on the READMENote: #556 also bumps the YouTube extension version, so whichever is merged second will need a trivial rebase of
metadata.json/ the changelog, which I will take care of.