fix: add first login totp reset flow - #126
Merged
Merged
Conversation
- Extract the reset flow into a reusable component - Handle pending sign-in users and password-verified TOTP removal - Preserve passkey challenges and return new authenticator setup data
- Return the affected user email when reset requires sign-in - Mask reset email on the TOTP page - Update migration copy and support centered flow text
addidotlol
marked this pull request as draft
September 20, 2026 19:26
addidotlol
marked this pull request as ready for review
September 20, 2026 20:27
lleyton
requested changes
Sep 20, 2026
lleyton
left a comment
lleyton
left a comment
Contributor
There was a problem hiding this comment.
What's the point of TOTP if you can reset it from your email?
- Remove the standalone TOTP reset dialog and signed-in reset path - Require legacy TOTP reset flow to run while signed out - Centralize reset and disable handling through verified password removal
lleyton
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do not merge