refact: Contact Mech - dispatch scaling wrt to fracture element type - #4083
Merged
Merged
Conversation
jafranc
added
type: cleanup / refactor
jafranc
changed the title
dkachuma
reviewed
Jun 15, 2026
jafranc
marked this pull request as ready for review
August 27, 2026 13:33
jafranc
requested review from
OmarDuran,
jhuang2601 and
rrsettgast
as code owners
August 27, 2026 13:33
jhuang2601
approved these changes
Aug 27, 2026
| setApplyDefaultValue( 5.e-02 ). | ||
| setDescription( "Tolerance for the sliding check" ); | ||
|
|
||
| registerWrapper( viewKeyStruct::symmetricString(), &m_isAnisotropic ). |
Contributor
There was a problem hiding this comment.
Duplicate input key registration for both m_isAnisotropic and m_symmetric?
| stiffDiagApprox[ i ][ j ] = E / ( ( 1.0 + nu )*( 1.0 - 2.0*nu ) ) * 4.0 / 9.0 * ( 2.0 - 3.0 * nu ) * charLength; | ||
|
|
||
| //TODO (jafranc) once stabilized, get rid of this ugly ternary | ||
| stiffDiagApprox[ i ][ j ] = m_isAnisotropic ? E / ( ( 1.0 + nu )*( 1.0 - 2.0*nu ) ) * 4.0 / 9.0 * ( 2.0 - 3.0 * nu ) * volume / bbox[j] / bbox[j] |
Contributor
There was a problem hiding this comment.
Potential divide-by-zero issue and add a lower bound guard for bbox
Contributor
Author
There was a problem hiding this comment.
Good catch ! I check for that earlier now, though such zero volume elements should not pass sanity checks in GEOS.
jhuang2601
added
ci: run CUDA builds
ci: run integrated tests
jafranc
commented
Aug 28, 2026
jafranc
left a comment
jafranc
left a comment
Contributor
Author
There was a problem hiding this comment.
Thank you @jhuang2601. Good catch you made.
This might need a rebaseline as eventhough the behavior is opt-in on a XML parameter, the default is reverted to what was in Matteo original branch and might not be in sync with baselines anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In [A]LM methods, we rely on computed tolerances to decide on the slip/stick/open dispatch. Those are strongly geometry related in their estimation of the local inverse of the stiffness from left/right neighbors. Originallym the method was implemented with hexahedron/quad mixed dimensionality assumption.
Now we are running with mixed and tetra meshes. The original assumption tends to render a stiffer system. This PR propose dispatch with old behavior for Hex/Quad and right angle Tetra/Triangle approximation for triangles. (Extensible if needed_
Extend to LM and LM w/ bubblewill be done in [wip] refact: Fit ALM as LM in the Poromechanics hierarchy #4101 if applied