Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
0a5f798
switch from molarity concentration to molality
frankfeifan Mar 14, 2026
befd8a9
make the timestep in unit test smaller as the jacobian is very sensit…
frankfeifan Mar 16, 2026
243c99c
Merge remote-tracking branch 'origin/develop' into feat/frankfei/mola…
frankfeifan Mar 16, 2026
e949cca
Merge remote-tracking branch 'origin/develop' into feat/frankfei/mola…
frankfeifan May 29, 2026
a36c649
Merge remote-tracking branch 'origin/develop' into feat/frankfei/mola…
frankfeifan Aug 31, 2026
851b21e
Merge remote-tracking branch 'origin/develop' into feat/frankfei/mola…
frankfeifan Sep 1, 2026
2e211f4
single reaction system across all regions to ensure consistent dof la…
frankfeifan Sep 1, 2026
c366f35
fix kinetic reaction rate with molality, uncrustify
frankfeifan Sep 1, 2026
816c048
rename to solventMassPerSolutionVolume to be more precise, and define…
frankfeifan Sep 2, 2026
078d45f
uncrustify
frankfeifan Sep 2, 2026
5fb7e32
Merge remote-tracking branch 'origin/develop' into feat/frankfei/mola…
frankfeifan Sep 2, 2026
c6228ba
plugged in activity model
frankfeifan Sep 4, 2026
174e032
applied solution scaling and fixed the normalizer
frankfeifan Sep 5, 2026
bb7c918
added smoke tests for bdot model and added log for equil. reaction run
frankfeifan Sep 5, 2026
82ecf46
Merge remote-tracking branch 'origin/develop' into feat/frankfei/mola…
frankfeifan Sep 5, 2026
5611172
No plot for some field variables
frankfeifan Sep 5, 2026
2848b41
Merge remote-tracking branch 'origin/feat/frankfei/molalityConcentrat…
frankfeifan Sep 5, 2026
ba33803
rebaseline
frankfeifan Sep 6, 2026
0c87a3e
fixed unused var
frankfeifan Sep 6, 2026
0a7813e
fixed CI tests
frankfeifan Sep 6, 2026
f39bd3c
Merge remote-tracking branch 'origin/develop' into feat/frankfei/acti…
frankfeifan Sep 8, 2026
b799e7f
Merge remote-tracking branch 'origin/develop' into feat/frankfei/mola…
frankfeifan Sep 10, 2026
f7e3384
Merge branch 'develop' into feat/frankfei/molalityConcentration
frankfeifan Sep 14, 2026
9fb8b70
fixed 1D chain reaction run and added to integrated test
frankfeifan Sep 15, 2026
d943022
Merge branch 'feat/frankfei/molalityConcentration' into feat/frankfei…
frankfeifan Sep 15, 2026
0ad02b9
Merge branch 'feat/frankfei/molalityConcentration' into feat/frankfei…
frankfeifan Sep 15, 2026
bf4f598
Merge branch 'feat/frankfei/activityModelAPI' into feat/frankfei/HPCR…
frankfeifan Sep 15, 2026
59c7129
enable additional equilibrium enforce constraint options
frankfeifan Sep 16, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion BASELINE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Notes
This file is designed to track changes to the integrated test baselines.
Any developer who updates the baseline ID in the .integrated_tests.yaml file is expected to create an entry in this file with the pull request number, date, and their justification for rebaselining.
These notes should be in reverse-chronological order, and use the following time format: (YYYY-MM-DD).

PR #3994 (2026-09-03) <https://storage.googleapis.com/geosx/integratedTests/baseline_integratedTests-pr3994-17525-4ae3593.tar.gz>
=====================
Introduce mimetic inner products for saddle-point operators and align face-centroid computation with exact volume integration on planar polyhedra.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
name="SinglePhaseReactiveFlow"
discretization="singlePhaseTPFA"
targetRegions="{ Medium, Source }"
initialDt="1e-5"
initialDt="1e-10"
writeLinearSystem="0"
logLevel="1">
<NonlinearSolverParameters
Expand All @@ -18,7 +18,7 @@
lineSearchAction="None"
timeStepIncreaseFactor="2"
logLevel="1"
maxAllowedResidualNorm="1e100"/>
maxAllowedResidualNorm="1e10"/>
<LinearSolverParameters
directParallel="1"/>
</SinglePhaseReactiveTransport>
Expand All @@ -44,7 +44,8 @@
referencePressure="0.0"
compressibility="0.0"
viscosibility="0.0"
chemicalSystemType="chainSerialAllKinetic"/>
chemicalSystemType="chainSerialAllKinetic"
solventMassPerSolutionVolume="1"/>

<CompressibleSolidConstantPermeability
name="rock"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<File name="./ChainSerial_base.xml" />
<File name="./ChainSerial_1DAllKinetic_base.xml" />
<File name="./ChainSerial_initialAggregate.xml" />
<File name="./ChainSerial_initialPrimaryConc.xml" />
<File name="./ChainSerial_logConc.xml" />
</Included>

Expand All @@ -25,17 +26,17 @@
maxTime="400">
<PeriodicEvent
name="outputs"
cycleFrequency="5"
timeFrequency="20"
target="/Outputs/vtkOutput"/>

<PeriodicEvent
name="logPrimarySpeciesHistoryCollection"
cycleFrequency="5"
timeFrequency="1"
target="/Tasks/logPrimarySpeciesCollection"/>

<PeriodicEvent
name="logPrimarySpeciesTimeHistoryOutput"
cycleFrequency="1"
timeFrequency="1"
target="/Outputs/logPrimarySpeciesHistoryOutput"/>

<PeriodicEvent
Expand All @@ -45,7 +46,7 @@

<PeriodicEvent
name="restarts"
cycleFrequency="500"
timeFrequency="100"
target="/Outputs/restartOutput"/>
</Events>

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<?xml version="1.0" ?>

<Problem>
<Included>
<File name="./ChainSerial_base.xml" />
<File name="./ChainSerial_1DAllKinetic_base.xml" />
<File name="./ChainSerial_initialAggregate.xml" />
<File name="./ChainSerial_initialPrimaryConc.xml" />
<File name="./ChainSerial_logConc.xml" />
</Included>

<Mesh>
<InternalMesh
name="mesh1"
elementTypes="{ C3D8 }"
xCoords="{ -1e-4, 0, 40.0 }"
yCoords="{ 0, 1 }"
zCoords="{ 0, 1 }"
nx="{ 1, 40 }"
ny="{ 1 }"
nz="{ 1 }"
cellBlockNames="{ cb-0_0_0, cb-1_0_0 }"/>
</Mesh>

<Events
maxTime="20">
<PeriodicEvent
name="outputs"
timeFrequency="5"
target="/Outputs/vtkOutput"/>

<PeriodicEvent
name="solverApplications"
maxEventDt="1"
target="/Solvers/SinglePhaseReactiveFlow"/>

<PeriodicEvent
name="restarts"
cycleFrequency="20"
target="/Outputs/restartOutput"/>
</Events>

</Problem>
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
initialCondition="1"
setNames="{ all }"
objectPath="ElementRegions/Medium"
fieldName="water_primarySpeciesAggregateConcentration"
fieldName="water_primarySpeciesConstraintValue"
component="0"
scale="1e-8"/>

Expand All @@ -17,7 +17,7 @@
initialCondition="1"
setNames="{ all }"
objectPath="ElementRegions/Medium"
fieldName="water_primarySpeciesAggregateConcentration"
fieldName="water_primarySpeciesConstraintValue"
component="1"
scale="1e-8"/>

Expand All @@ -26,7 +26,7 @@
initialCondition="1"
setNames="{ all }"
objectPath="ElementRegions/Medium"
fieldName="water_primarySpeciesAggregateConcentration"
fieldName="water_primarySpeciesConstraintValue"
component="2"
scale="1e-8"/>

Expand All @@ -36,7 +36,7 @@
initialCondition="1"
setNames="{ all }"
objectPath="ElementRegions/Source"
fieldName="water_primarySpeciesAggregateConcentration"
fieldName="water_primarySpeciesConstraintValue"
component="0"
scale="1.0"/>

Expand All @@ -45,7 +45,7 @@
initialCondition="1"
setNames="{ all }"
objectPath="ElementRegions/Source"
fieldName="water_primarySpeciesAggregateConcentration"
fieldName="water_primarySpeciesConstraintValue"
component="1"
scale="1e-8"/>

Expand All @@ -54,7 +54,7 @@
initialCondition="1"
setNames="{ all }"
objectPath="ElementRegions/Source"
fieldName="water_primarySpeciesAggregateConcentration"
fieldName="water_primarySpeciesConstraintValue"
component="2"
scale="1e-8"/>
</FieldSpecifications>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<?xml version="1.0" ?>

<Problem>
<FieldSpecifications>
<!-- INITIAL LOG CONCENTRATIONS AT MEDIUM, FOR SYSTEMS WITH NO EQUILIBRIUM REACTIONS -->
<FieldSpecification
name="initialLog_C1_medium"
initialCondition="1"
setNames="{ all }"
objectPath="ElementRegions/Medium"
fieldName="logPrimarySpeciesConcentration"
component="0"
scale="-18.420680744"/>

<FieldSpecification
name="initialLog_C2_medium"
initialCondition="1"
setNames="{ all }"
objectPath="ElementRegions/Medium"
fieldName="logPrimarySpeciesConcentration"
component="1"
scale="-18.420680744"/>

<FieldSpecification
name="initialLog_C3_medium"
initialCondition="1"
setNames="{ all }"
objectPath="ElementRegions/Medium"
fieldName="logPrimarySpeciesConcentration"
component="2"
scale="-18.420680744"/>
</FieldSpecifications>
</Problem>
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
<?xml version="1.0" ?>

<Problem>
<FieldSpecifications>
<!-- INITIAL PRIMARY CONCENTRATIONS AT MEDIUM -->
<FieldSpecification
name="initialPrimary_C1_medium"
initialCondition="1"
setNames="{ all }"
objectPath="ElementRegions/Medium"
fieldName="water_initialPrimarySpeciesConcentration"
component="0"
scale="1e-8"/>

<FieldSpecification
name="initialPrimary_C2_medium"
initialCondition="1"
setNames="{ all }"
objectPath="ElementRegions/Medium"
fieldName="water_initialPrimarySpeciesConcentration"
component="1"
scale="1e-8"/>

<FieldSpecification
name="initialPrimary_C3_medium"
initialCondition="1"
setNames="{ all }"
objectPath="ElementRegions/Medium"
fieldName="water_initialPrimarySpeciesConcentration"
component="2"
scale="1e-8"/>

<!-- INITIAL PRIMARY CONCENTRATIONS AT SOURCE -->
<FieldSpecification
name="initialPrimary_C1_source"
initialCondition="1"
setNames="{ all }"
objectPath="ElementRegions/Source"
fieldName="water_initialPrimarySpeciesConcentration"
component="0"
scale="1.0"/>

<FieldSpecification
name="initialPrimary_C2_source"
initialCondition="1"
setNames="{ all }"
objectPath="ElementRegions/Source"
fieldName="water_initialPrimarySpeciesConcentration"
component="1"
scale="1e-8"/>

<FieldSpecification
name="initialPrimary_C3_source"
initialCondition="1"
setNames="{ all }"
objectPath="ElementRegions/Source"
fieldName="water_initialPrimarySpeciesConcentration"
component="2"
scale="1e-8"/>
</FieldSpecifications>
</Problem>
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@
referencePressure="0.0"
compressibility="0.0"
viscosibility="0.0"
chemicalSystemType="momasEasy"/>
chemicalSystemType="momasEasy"
solventMassPerSolutionVolume="1"/>

<CompressibleSolidConstantPermeability
name="rock_a"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
lineSearchAction="None"
timeStepIncreaseFactor="1.2"
logLevel="2"
maxAllowedResidualNorm="1e100"/>
maxAllowedResidualNorm="1e8"/>
<LinearSolverParameters
directParallel="0"/>
</SinglePhaseReactiveTransport>
Expand Down Expand Up @@ -50,7 +50,8 @@
referencePressure="0.0"
compressibility="0.0"
viscosibility="0.0"
chemicalSystemType="momasEasy"/>
chemicalSystemType="momasEasy"
solventMassPerSolutionVolume="1"/>

<CompressibleSolidConstantPermeability
name="rock_a"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@
referencePressure="0.0"
compressibility="0.0"
viscosibility="0.0"
chemicalSystemType="momasEasy"/>
chemicalSystemType="momasEasy"
solventMassPerSolutionVolume="1"/>

<CompressibleSolidConstantPermeability
name="rock_a"
Expand Down
Loading
Loading