Fix SuperLU_DIST URL hash - #365
Closed
zwx19961130 wants to merge 1 commit into
Closed
zwx19961130 wants to merge 1 commit into
zwx19961130 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change corrects an objectively invalid SHA256 value and aligns with how the hash is consumed (URL_HASH SHA256=${SUPERLU_URL_HASH}) without introducing additional behavior changes.
Pull request overview
This PR fixes the SHA256 checksum used to verify the downloaded SuperLU_DIST source archive (commit 0f6efc3) during the CMake ExternalProject fetch step, preventing hash verification failures.
Changes:
- Corrected
SUPERLU_URL_HASHby removing an extra trailing character so it matches the actual SHA256 of the archive.
File summaries
| File | Description |
|---|---|
| CMakeLists.txt | Fixes the SuperLU_DIST archive SHA256 used by ExternalProject_Add(... URL_HASH SHA256=...) so download verification succeeds. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Thank you for proposing a fix! Replaced by #364 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the SHA256 checksum for the SuperLU_DIST archive at commit
0f6efc3.The existing checksum contains an extra trailing
a, making it invalid and causing the archive hash verification to fail.Testing
Verified that the SHA256 of the downloaded archive is:
49cd47da22fe72a37011e8dfaf94bd63ad8d61cc8144eac7a571bcbd0a2edf58With the corrected checksum, the SuperLU_DIST download and build proceed successfully.