Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operator could sweep the force-skip connector and make both Quick-Challenge and Force-Skip-Kickoff unspendable, bypassing enforcement of the one-active-kickoff rule.
Audit finding: M29.
Companion node PR: GOATNetwork/bitvm-node#527. That change supplies the committee key and integrates both signatures into the graph pre-signing round.
This changes connector construction and the transaction signing API; deploy with the companion node change.
Validation: the companion node branch includes a full operator/committee pre-signing regression covering committee signature verification, rejection of the operator key, and simplified graph round-tripping. Its zkm notes record passing bitvm-gc/node tests and clippy; these were not rerun during this review.