Repository navigation
Conversation
blake-pro
approved these changes
Nov 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit item M5. Open against
dev. Wire change: operator and verifier nodes must run the same version (this ships with the redeploy).The operator bound a GenCircuits
verifier_pubkeyto the first peer that claimed it. A registered verifier could claim another verifier's key first; the real holder was then refused as "already bound to another peer", and the graph stalled because the selected key had no one to endorse it.verifier_pubkeyover a domain tag, instance id, graph id, the key and the sender's peer id. The operator ignores a GenCircuits whose signature does not verify for its gossip author.Tests: the holder's message verifies for its own peer only; another peer's signature over the holder's key, and the holder's signature moved to another graph, are refused. Node tests and workspace clippy pass.
Validation results above are recorded in the zkm PR notes. Branch scope and diff formatting were checked locally; builds and tests were not rerun during publication.