Repository navigation
Conversation
blake-pro
approved these changes
Nov 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit item M23. Open against
dev.add_node_rewardreads the node's reward, adds the increment in Rust and passes the new total toupdate_node_reward_by_peer_id, whose SQL then ranreward = reward + ?. Each reward event therefore added the old total again, so/v1/nodesshowed a value that grew much faster than the real reward.update_node_reward_by_peer_idnow stores the total it is given (reward = ?); the addition happens only in Rust. sqlx offline cache updated.Tests: two rewards of 5 on a fresh node give 10 (15 before the fix). Node and store tests, clippy and fmt pass.
Validation results above are recorded in the zkm PR notes. Branch scope and diff formatting were checked locally; builds and tests were not rerun during publication.