Repository navigation
Conversation
blake-pro
approved these changes
Nov 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit item M32. Open against
dev.WithdrawHappyPath, WithdrawUnhappyPath and WithdrawDisproved entities from the subgraph were written straight to OperatorTake1, OperatorTake2 and Disprove. A terminal status takes the graph out of
graph_scanand obsoletes the instance's other graphs, so a wrong or compromised subgraph could make the node stop challenging a graph that is still open, and the operator's Take-2 would go through.gateway_get_withdraw_data(graph_id): Take outcomes needComplete, Disproved needsDisproved. An outcome the Gateway does not hold is dropped with a warning; the graph stays followed on Bitcoin, where its real outcome is still observed.Tests: outcomes for withdraws still
Processingor alreadyDisprovedare dropped, matching ones are kept, and a failed lookup is an error. Node tests and clippy pass.Validation results above are recorded in the zkm PR notes. Branch scope and diff formatting were checked locally; builds and tests were not rerun during publication.