Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit item M7. Open against
dev.A node can hold only the operator's copy of a graph, without the committee pre-signatures. When Gateway's
PostGraphDataarrives, the watcher moves the copy to OperatorDataPushed anyway. Several places then judged "finalized" by status: the node served that copy to peers asking for the finalized one, and never pulled the real one. A verifier holding such a copy cannot build the peg-out transactions that need the committee signatures."Finalized" now means the stored definition has
committee_pre_signedset. The store paths verify the signatures before they write a definition with that flag, so the flag is safe to read.GetGraphasking for the finalized copy is answered only from a definition with the flag set, whatever the status.The flag is read from the raw JSON without rebuilding the graph (
raw_definition_committee_pre_signed).Review notes
Tests: an operator-only copy past OperatorPresigned is not served as finalized; a posted graph held only as the operator's copy is pulled by every role; a finalized pull runs while only the operator's copy is stored. Each fails without the fix. Node tests, workspace clippy with
-D warningsand fmt pass.The test coverage and validation notes above are from the zkm PR notes. Branch scope and diff formatting were checked locally; builds and tests were not rerun during publication.