Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit item M8. Open against
dev.Only the operator gave up a setup at the instance's abandon height (
H_p + T0 + B). On verifier and committee nodes nothing ended a graph whose operator went offline, or a graph left out because other graphs carried the instance:The abandon scan now runs on every role. On a non-operator it reports two kinds of setup:
Past the abandon height:
On a non-operator, a failed instance does not skip the check: the instance cleanup obsoletes graph rows but never reaches a setup that has no row. The operator path is unchanged.
Review notes
list_engine_aggregates_by_status, over graph aggregates with no graph row.Tests: a committee graph unfinished at the abandon height turns Obsoleted and closes its nonce delivery, while a finalized graph is left alone; a verifier setup whose graph never arrives closes its GenCircuits delivery and is reported once. Node and store tests, workspace clippy with
-D warningsand fmt pass.The test coverage and validation notes above are from the zkm PR notes. Branch scope and diff formatting were checked locally; builds and tests were not rerun during publication.