Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit items M9 and M15. Open against
dev.The relayer's Goat calls handled a revert in two opposite ways:
postGraphDataand the peg-out settlement calls (proceedWithdraw,finishWithdraw*) treated any revert as a permanent rejection. Their job ids are stable, so they never ran again. A revert from a lagging or load-balanced Goat RPC ended the job, and only another relayer or a human could finish the call (M9).postPeginDataretried every revert forever, so thePostPeginDataRejectedalert never fired (M15).Now a revert gets 5 consecutive runs, a minute apart. Every one of these jobs reads the Goat state before calling (graph already posted, withdraw status, pegin status), so if another relayer made the call meanwhile, the next run ends as done. If the call still reverts after 5 runs, the existing rejection path takes over and alerts:
post_graph_data_rejected,pegout_action_rejected, orPostPeginDataRejected. The count is kept in the job's last error. Any other failure in between, such as waiting for SPV, starts the count again.A rejected
postGraphDatanow fails its job instead of finishing it with a note, sopost_graph_data_rejectedfires. That alert only fired for a failed job, so it was never raised before.The client's own checks before
postPeginData("not a pending pegin request", amount mismatch, not a committee member) stay final at once.Review notes
Tests: a revert is retried for 4 consecutive runs and then left to the rejection path; another failure in between starts the count again; other errors are untouched. The runner arms themselves are not covered: the graph test harness scripts its own runners. Node tests, workspace clippy with
-D warningsand fmt pass.The test coverage and validation notes above are from the zkm PR notes. Branch scope and diff formatting were checked locally; builds and tests were not rerun during publication.