Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit item M16. Open against
dev.Gateway.postPeginDatadeductsminPeginFeeSats + amount * peginFeeRate / 10000and reverts withFeeTooHighwhen that fee is not below the peg-in amount. Neither the node norpostPeginRequestchecks this up front. So a request too small for the fee went through the whole flow (answer, graphs, Peg-In-Confirm), and only the finalpostPeginDatafailed. That failure is permanent, and the BTC stays in the n-of-n Connector-0.Before answering, a committee node now reads both fee parameters from the Gateway and refuses a request whose amount does not exceed the fee. The refusal is an invalid peg-in request: the answer job records it as rejected with a warning and does not retry. Without enough committee answers, the request expires as usual.
Review notes
u128with the contract's formula, so an extreme amount cannot overflow on the node.postPeginDatais still caught by the existing rejection alert (M15).Tests: the fee matches the Gateway formula, including the rounding and overflow edge cases. Node tests, workspace clippy with
-D warningsand fmt pass.The test coverage and validation notes above are from the zkm PR notes. Branch scope and diff formatting were checked locally; builds and tests were not rerun during publication.