Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit items M26 and M27. Open against
dev.Graph rebuilds (M26).
/v1/graphs/{id}/txand/v1/graphs/{id}/txntake no auth and have no cache or rate limit, and each request did the full graph work twice: once inload_validated_graph_definition, which rebuilds the graph to check its pre-signatures, and once more in the handler'sfrom_simplified. Both ran on the tokio workers while the request held a pool connection.load_validated_graph_definitionis split into a database read (read_graph_definition) and a CPU check (StoredGraphDefinition::build).buildreturns the graph it already rebuilt. Both endpoints now:buildon the blocking pool, at most 2 at a time (GRAPH_BUILDS);Other callers of
load_validated_graph_definitionare unchanged.Connections during external calls (M27). The pool has 10 connections, shared with the engine.
get_instances,get_instance,get_graph,get_graphsand the two endpoints above kept their connection through the esplora and Goat calls, so plain GET requests could take every connection; engine and inbox writes then timed out and/v1/healthreturned 503. Each of them now releases its connection after its last query.Review notes
send-challenge,send-verifier-challenge) still use the old path; they are behindrpc-debug-endpoints.Tests: the public build rejects an unsigned graph with the same error as the validated load, and the read returns nothing for an unknown graph and fails for a mismatched instance. Node tests, workspace clippy with
-D warnings(with and withoutrpc-debug-endpoints) and fmt pass.The test coverage and validation notes above are from the zkm PR notes. Branch scope and diff formatting were checked locally; builds and tests were not rerun during publication.