Repository navigation
Conversation
added 2 commits
November 11, 2026 06:39
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit items M39 and M40. Open against
dev.install-bitvm.sh (M39). The script installed nothing, and every skill that calls it (upgrade, pegout, pegin-request, challenge, run-*-node) failed with it:
.sha256files list the archive asrelease-artifacts/<archive>, sosha256sum -cin the download directory found nothing andset -eexited../binwas resolved inside the temporary directory, which the EXIT trap then deleted.set -uerror).bitvm2-node-*, while the script asks forbitvm-node-*.Fixes:
.sha256format.release.ymlnow writes only the archive name.Checked by installing v0.3.3 from GitHub with the default
--dir ./bin.Toolchain and image tags (M40).
ci.ymlpinned the zkmup commit and toolchain version.release.yml,docker.ymland the proof-builder image workflow ransetup.shfrom the toolchain repository'smaininstead, so releases were built with a toolchain CI never tested, and a change to that repository went straight into them. All four workflows now use one composite action,.github/actions/install-ziren, which holds the pinned commit and version. The pinned version also ships the aarch64 macOS build thatrelease.ymlneeds.:<Cargo version>on every dev push, so an operator pinned to0.4.0pulled unreleased dev builds. The version tag is now pushed only frommain; other pushes tagdev-<sha>.:latestis unchanged.Review notes
ci.ymlonly.dev-<sha>orlatest.The test coverage and validation notes above are from the zkm PR notes. Branch scope and diff formatting were checked locally; builds and tests were not rerun during publication.