Repository navigation
fix: preserve Kotlin trailing commas in ReactHost calls - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve an existing trailing comma when adding the CodePush bundle argument to the Android ReactHost call. Valid Kotlin previously became a double comma and failed compilation.
Details
Testing steps
Run the project checks:
pnpm install --frozen-lockfile pnpm run lint pnpm run format pnpm run typecheck pnpm run test pnpm run build pnpm run changelog:check pnpm run security:check npm pack --dry-runConfirm they pass and the generated ReactHost call keeps one comma before the CodePush argument.