Skip to content

fix: preserve Kotlin trailing commas in ReactHost calls - #59

Merged
GSTJ merged 1 commit into
masterfrom
fix/kotlin-trailing-comma
Nov 16, 2026
Merged

GSTJ merged 1 commit into
masterfrom
fix/kotlin-trailing-comma

Conversation

@GSTJ

@GSTJ GSTJ commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Summary

Preserve an existing trailing comma when adding the CodePush bundle argument to the Android ReactHost call. Valid Kotlin previously became a double comma and failed compilation.

Details

  • Keep the argument after package initialization and preserve idempotency.
  • Cover trailing commas with line comments, block comments, and the SDK 57 MainApplication template.
  • Local harness executes the original and fixed compiled helper. This proves generated source output; an Android device build was not run.

Local before and after repro

Testing steps

Run the project checks:

pnpm install --frozen-lockfile
pnpm run lint
pnpm run format
pnpm run typecheck
pnpm run test
pnpm run build
pnpm run changelog:check
pnpm run security:check
npm pack --dry-run

Confirm they pass and the generated ReactHost call keeps one comma before the CodePush argument.

@GSTJ
GSTJ enabled auto-merge (squash) November 16, 2026 12:10
@GSTJ
GSTJ merged commit 9ab8a91 into master Nov 16, 2026
5 checks passed
@GSTJ
GSTJ deleted the fix/kotlin-trailing-comma branch November 16, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant