Update main branch - #111
Open
maksymiuks wants to merge 5 commits into
Open
maksymiuks wants to merge 5 commits into
maksymiuks wants to merge 5 commits into
Conversation
…tory (#107) * Add option to specify options inherited by subprocesses * Match repositories by prefix in strip_src_contrib() R-universe repositories report the `Repository` field of `available.packages()` as a full, per-package tarball url (`.../src/contrib/<pkg>_<ver>.tar.gz?sha256=...&file=`) rather than the plain contrib url that CRAN-like repositories report. Comparing that field to `contrib.url(repo)` with `==` therefore never matched, so `strip_src_contrib()` returned `character(0)`, `pkg_origin_repo()` stored an empty `repos`, and `get_package_source()` failed at check time with `subscript out of bounds`. Match by prefix instead, so a per-package tarball url still resolves back to its originating repository. `contrib.url()` is left at its default `type`, matching the type `available_packages()` uses to produce the `Repository` field, so binary repositories keep working. No change is needed in `get_package_source()`: R-universe crafts the `Repository` field so that appending `/<pkg>_<ver>.tar.gz` (what `utils::download.packages()` does, and what `get_package_source()` already did) yields a valid download url. Fixes #106 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Szymon Maksymiuk <32574056+maksymiuks@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
* Add option to specify options inherited by subprocesses * Slight improvments to the install_process env * Update snapshot and NEWS
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 82.84% 82.07% -0.78%
==========================================
Files 29 29
Lines 2262 2309 +47
==========================================
+ Hits 1874 1895 +21
- Misses 388 414 +26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.