Repository navigation
Stop deleting Gradle lock files before assembleDebug (MOB-469) - #135
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
clear_stale_gradle_locks/1and its call ingradle_assemble/0, and the test that pinned it. Gradle's locks are OS-backed FileChannel locks released when the holding JVM exits; deleting the file only unlinks the inode and breaks mutual exclusion between concurrent builds (same class as MOB-468).No lock-timeout hint: gradlew output is streamed, not captured, and Gradle's own timeout message is the diagnostic (owner PID when known).
Review: Codex (read-only). Round 1 DO NOT MERGE on CHANGELOG overstatement only (wrapper .lck timeouts don't name a PID; --stop only stops same-version daemons; the historical-cause claim wasn't supported) — fixed. Deletion itself judged correct; kill -9 during wrapper download doesn't leave a held lock (FileLock released on JVM exit; .part/.ok retry).