Skip to content

[Fixes #14503] Move document upload and replace to the upload module - #14504

Open
mattiagiupponi wants to merge 18 commits into
masterfrom
document_upload
Open

[Fixes #14503] Move document upload and replace to the upload module#14504
mattiagiupponi wants to merge 18 commits into
masterfrom
document_upload

Conversation

@mattiagiupponi

Copy link
Copy Markdown
Contributor

ref #14503

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Aug 12, 2026
@mattiagiupponi mattiagiupponi linked an issue Aug 12, 2026 that may be closed by this pull request
Comment thread pyproject.toml

# GeoNode org maintained apps.
"django_geonode_mapstore_client @ https://github.com/GeoNode/geonode-mapstore-client/archive/refs/heads/master.zip",
"django_geonode_mapstore_client @ https://github.com/dsuren1/geonode-mapstore-client//archive/refs/heads/issue_2616_built.zip",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is pointing to the test FE branch, we will change this once the FE is ready too

@gitguardian

gitguardian Bot commented Aug 12, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
35667410 Triggered Generic Password 5a76ce7 geonode/upload/handlers/document/tests.py View secret
34065353 Triggered Bearer Token 5a76ce7 docs/src/development/api.md View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Comment thread geonode/upload/api/views.py Fixed
Comment thread geonode/upload/handlers/common/document.py Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move document upload and replace to the upload module

3 participants