Skip to content

Feat/external time series - #1378

Open
BenPinet wants to merge 3 commits into
nextfrom
feat/external-time-series
Open

BenPinet wants to merge 3 commits into
nextfrom
feat/external-time-series

Conversation

@BenPinet

Copy link
Copy Markdown
Member

No description provided.

BenPinet and others added 3 commits October 21, 2026 15:30
Time series computed outside of a BRep (e.g. by a simulator) are stored
per unique vertex and per Block polyhedron, saved/loaded in a native
og_ets file and written on the Block meshes with apply_to.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Register an og_ets reader in BRepTimeSeriesInputFactory: it loads the
ExternalTimeSeriesHelpers and applies them on the BRep, so
load_brep_time_series handles the native format.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A Block time step with the same name and time as an applied one is
deleted first, so that applying helpers built with other attribute ids
(e.g. a reloaded simulation) does not duplicate the step.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BenPinet
BenPinet requested a review from BotellaA October 21, 2026 13:47
@github-actions

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v21.1.8) reports: 11 concern(s)
  • src/geode/model/common.cpp:40:53: warning: [bugprone-suspicious-stringview-data-usage]

    result of a data() call may not be null terminated, provide size information to the callee to prevent potential issues

       40 |             geode::OpenGeodeBRepOutput::extension().data() );
          |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
  • src/geode/model/common.cpp:47:56: warning: [bugprone-suspicious-stringview-data-usage]

    result of a data() call may not be null terminated, provide size information to the callee to prevent potential issues

       47 |             geode::OpenGeodeSectionOutput::extension().data() );
          |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
  • src/geode/model/common.cpp:54:62: warning: [bugprone-suspicious-stringview-data-usage]

    result of a data() call may not be null terminated, provide size information to the callee to prevent potential issues

       54 |             geode::OpenGeodeBRepTimeSeriesInput::extension().data() );
          |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
  • src/geode/model/common.cpp:61:53: warning: [bugprone-suspicious-stringview-data-usage]

    result of a data() call may not be null terminated, provide size information to the callee to prevent potential issues

       61 |             geode::OpenGeodeBRepOutput::extension().data() );
          |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
  • src/geode/model/common.cpp:68:56: warning: [bugprone-suspicious-stringview-data-usage]

    result of a data() call may not be null terminated, provide size information to the callee to prevent potential issues

       68 |             geode::OpenGeodeSectionOutput::extension().data() );
          |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
  • src/geode/model/helpers/external_time_series_helpers.cpp:46:34: warning: [readability-identifier-length]

    parameter name 'to' is too short, expected at least 3 characters

       46 |         geode::AttributeManager& to,
          |                                  ^
  • src/geode/model/helpers/external_time_series_helpers.cpp:68:71: warning: [readability-identifier-length]

    parameter name 'to' is too short, expected at least 3 characters

       68 |         const geode::AttributeManager& from, geode::AttributeManager& to )
          |                                                                       ^
  • src/geode/model/helpers/external_time_series_helpers.cpp:110:24: warning: [readability-identifier-length]

    variable name 'it' is too short, expected at least 3 characters

      110 |             const auto it = block_polyhedron_attributes_.find( block_id );
          |                        ^
  • src/geode/model/helpers/external_time_series_helpers.cpp:118:24: warning: [readability-identifier-length]

    variable name 'it' is too short, expected at least 3 characters

      118 |             const auto it = block_polyhedron_attributes_.find( block_id );
          |                        ^
  • tests/model/test-external-time-series-helpers.cpp:61:59: warning: [cppcoreguidelines-avoid-magic-numbers]

    1. is a magic number; consider replacing it with a named constant
       61 |         return { static_cast< double >( polyhedron ), 1., 2. };
          |                                                           ^
  • tests/model/test-external-time-series-helpers.cpp:191:6: warning: [misc-use-internal-linkage]

    function 'test' can be made static or moved into an anonymous namespace to enforce internal linkage

      191 | void test()
          |      ^
          | static 

Have any feedback or feature suggestions? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant