Skip to content

fix(teimestepLabel): move label to top of timestep bar to prevent som… #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenPinet merged 3 commits into from
Oct 21, 2026
Merged

fix(teimestepLabel): move label to top of timestep bar to prevent som… #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a25d75
fix(teimestepLabel): move label to top of timestep bar to prevent som…
MaxNumerique Oct 21, 2026
bec79c7
Merge branch 'next' of https://github.com/Geode-solutions/OpenGeodeWe…
MaxNumerique Oct 21, 2026
7100170
trigger
MaxNumerique Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 31 additions & 37 deletions app/components/Viewer/Options/TimeStepSlider.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,56 +23,50 @@ function commitTimeStep(value: number): void {

function formatTime(index: number): string {
const time = timeSteps[index];
return time === undefined ? "" : `t = ${time}`;
return time === undefined ? "" : `timestep = ${time}`;
}
</script>

<template>
<v-slider
v-if="timeSteps.length > 1"
data-testid="timeStepSlider"
v-model="sliderTimeStep"
:min="0"
:max="timeSteps.length - 1"
:step="1"
color="primary"
density="compact"
class="time-step-slider mt-3"
hide-details
show-ticks="always"
:tick-size="10"
thumb-label="hover"
@end="commitTimeStep"
@keyup="commitTimeStep(sliderTimeStep)"
>
<template #prepend>
<span data-testid="timeStepValue" class="time-step-value">
{{ formatTime(sliderTimeStep) }}
</span>
</template>
<template #thumb-label="{ modelValue }">{{ formatTime(modelValue) }}</template>
<template #tick-label="{ index }">
<span class="time-step-tick">
<span class="v-slider-thumb__label time-step-tick-label">
<span class="v-slider-thumb__label-wedge" />
{{ formatTime(index) }}
<div v-if="timeSteps.length > 1" class="mt-3">
<div data-testid="timeStepValue" class="time-step-value">
{{ formatTime(sliderTimeStep) }}
</div>
<v-slider
data-testid="timeStepSlider"
v-model="sliderTimeStep"
:min="0"
:max="timeSteps.length - 1"
:step="1"
color="primary"
density="compact"
class="time-step-slider"
hide-details
show-ticks="always"
:tick-size="10"
thumb-label="hover"
@end="commitTimeStep"
@keyup="commitTimeStep(sliderTimeStep)"
>
<template #thumb-label="{ modelValue }">{{ formatTime(modelValue) }}</template>
<template #tick-label="{ index }">
<span class="time-step-tick">
<span class="v-slider-thumb__label time-step-tick-label">
<span class="v-slider-thumb__label-wedge" />
{{ formatTime(index) }}
</span>
</span>
</span>
</template>
</v-slider>
</template>
</v-slider>
</div>
</template>

<style scoped>
.time-step-value {
min-width: 32px;
white-space: nowrap;
font-size: 0.8125rem;
}

.time-step-slider.v-slider.v-input--horizontal :deep(.v-input__prepend) {
margin-inline-end: 4px;
}

.time-step-slider :deep(.v-slider-thumb__label) {
width: auto;
white-space: nowrap;
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/components/AttributeSelector.nuxt.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ describe("attributeSelector time steps", () => {
const wrapper = await mountSelector("temperature", 1);

expect(wrapper.find('[data-testid="timeStepSlider"]').exists()).toBe(true);
expect(wrapper.find('[data-testid="timeStepValue"]').text()).toBe("t = 1");
expect(wrapper.find('[data-testid="timeStepValue"]').text()).toBe("timestep = 1");
});

test("hides the slider for a non temporal attribute", async () => {
Expand Down
Loading