Repository navigation
Conversation
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
|
Contributor
Author
|
Closing for now: with #6861, calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Goal
A channel list whose filter contains the user's id only worked for one user: after a switch, the new user's list was queried with the previous user's id unless the app called
setFiltersor recreated the view model, and predefined filters had no way to change at all.Part of AND-1667. Stacked on #6861.
Implementation
ChannelListViewModelFactoryconstructors in Compose and XML that take the filter as(User) -> FilterObject, and predefined filter values as(User) -> Map<String, Any>.setFiltersstill takes over from it.nullas the first argument now need a cast, since it matches both overloads.Testing
ChannelListViewModelTests cover a switch to another user, the same user logging back in,setFiltersoverriding a filter built from the user, and predefined values per user.